Implement string_to_not_be_blank assertion #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrik-kuehl
force-pushed
the
implement-string_to_not_be_blank-assertion
branch
from
d3f4f74
to
da26f24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
expect/string_to_not_be_blankassertion to assert that a given string is neither empty nor consists only of whitespace characters.I'm not quite sure if my decision to transform the value of
actualviastring.inspectto make it easier to read, especially in cases where users are presented with whitespace-only strings, aligns well with your prior decisions.Simply outputting the value makes it hard to read since, well, we're looking at strings that potentially consist only of whitespace. I could also remove the double quotes if this is more desirable.